Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary (required)
Add statement timeout for RO sessions, there's a change to the app factory config that I snuck in with this PR removing an unnecessary context push.
Required reviewers
2-3 devs
Impacted areas of the application
General components of the application that this PR will affect:
How to test
pull this PR
pytestset an artificially low statement timeout locally
export SQLA_STATEMENT_TIMEOUT=1flask runRun any query and you should see a 408 error, you can try a 404 and 422 as well:
408: http://127.0.0.1:5000/v1/committees/?page=1&per_page=20&filing_frequency=M&sort=name&sort_hide_null=false&sort_null_only=false&sort_nulls_last=false
404: http://127.0.0.1:5000/v1/committes/?page=1&per_page=20&filing_frequency=M&sort=name&sort_hide_null=false&sort_null_only=false&sort_nulls_last=false
422: http://127.0.0.1:5000/v1/committees/?page=1&per_page=20&filing_frequency=ZZ&sort=name&sort_hide_null=false&sort_null_only=false&sort_nulls_last=false